Discussion:
[PATCH] mesa/bindless: fix missing image _Layer initialization
Add Reply
Ilia Mirkin
2017-12-30 05:30:23 UTC
Reply
Permalink
Raw Message
Some later code relies on _Layer to set first/last_layer. Make sure it's
always initialized.

Detected by valgrind's conditional jump/move with uninit value logic.

Signed-off-by: Ilia Mirkin <***@alum.mit.edu>
---
src/mesa/main/texturebindless.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/src/mesa/main/texturebindless.c b/src/mesa/main/texturebindless.c
index f062ea904a1..9aaa0367c2d 100644
--- a/src/mesa/main/texturebindless.c
+++ b/src/mesa/main/texturebindless.c
@@ -327,6 +327,7 @@ get_image_handle(struct gl_context *ctx, struct gl_texture_object *texObj,
} else {
imgObj.Layered = GL_FALSE;
imgObj.Layer = 0;
+ imgObj._Layer = 0;
}

/* Request a new image handle from the driver. */
--
2.13.6
Loading...