Discussion:
[Bug 101560] SPIR-V OpSwitch with int64 not supported even though shaderInt64 is true
Add Reply
b***@freedesktop.org
2017-07-04 08:41:57 UTC
Reply
Permalink
Raw Message
https://bugs.freedesktop.org/show_bug.cgi?id=101560

***@gmail.com changed:

What |Removed |Added
----------------------------------------------------------------------------
Component|Drivers/Vulkan/intel |Drivers/Vulkan/radeon
Assignee|intel-3d-***@lists.freedes |mesa-***@lists.freedesktop.
|ktop.org |org
QA Contact|intel-3d-***@lists.freedes |mesa-***@lists.freedesktop.
|ktop.org |org

--- Comment #1 from ***@gmail.com ---
I'm switching this to be a bug in radv because commit
1bc40ae9524477de9d4f73b57b3ae69a40923695 enabled int64 support in radv even
though the spir-v to nir translation code hasn't been fixed yet.
--
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
b***@freedesktop.org
2017-07-05 22:41:43 UTC
Reply
Permalink
Raw Message
https://bugs.freedesktop.org/show_bug.cgi?id=101560

--- Comment #2 from Jason Ekstrand <***@jlekstrand.net> ---
Ugh... I guess I didn't read the language on OpSwitch all that carefully the
first time around. This is going to be exceedingly painful to do correctly.
In order to know the number of switch cases, we have to know the bit size of
the selector. However, we need to know the switch cases early when we do the
initial CFG walk and, at that point, we haven't processed any instructions
other than control-flow so we have no way to know the bit size of the selector.
--
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
b***@freedesktop.org
2017-07-06 02:11:30 UTC
Reply
Permalink
Raw Message
https://bugs.freedesktop.org/show_bug.cgi?id=101560

--- Comment #3 from ***@gmail.com ---
you could implement an initial type-deduction pass; you shouldn't need to know
the cfg for that to work, because the OpPhi instructions state their type.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
b***@freedesktop.org
2017-12-03 13:58:12 UTC
Reply
Permalink
Raw Message
https://bugs.freedesktop.org/show_bug.cgi?id=101560

Bas Nieuwenhuizen <***@basnieuwenhuizen.nl> changed:

What |Removed |Added
----------------------------------------------------------------------------
Component|Drivers/Vulkan/radeon |Drivers/Vulkan/Common
CC| |***@freedesktop.org,
| |***@chromium.org,
| |***@fooishbar.org
QA Contact|mesa-***@lists.freedesktop. |
|org |
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
b***@freedesktop.org
2017-12-07 01:53:41 UTC
Reply
Permalink
Raw Message
https://bugs.freedesktop.org/show_bug.cgi?id=101560

--- Comment #4 from Jason Ekstrand <***@jlekstrand.net> ---
I have a branch for this now:

https://cgit.freedesktop.org/~jekstrand/mesa/log/?h=wip/spirv-type-tracking
--
You are receiving this mail because:
You are the assignee for the bug.
b***@freedesktop.org
2017-12-12 06:43:28 UTC
Reply
Permalink
Raw Message
https://bugs.freedesktop.org/show_bug.cgi?id=101560

Jason Ekstrand <***@jlekstrand.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED

--- Comment #5 from Jason Ekstrand <***@jlekstrand.net> ---
This should be fixed by the following commit:

commit df657ebb68a000b031d1b052748af5df4b645b59
Author: Jason Ekstrand <***@intel.com>
Date: Wed Dec 6 10:01:22 2017 -0800

spirv: Add support for all bit sizes in OpSwitch

Reviewed-by: Ian Romanick <***@intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101560
--
You are receiving this mail because:
You are the assignee for the bug.
Loading...