Discussion:
[PATCH] radv: Also set DCC params for sampling for input attachment usage.
Add Reply
Bas Nieuwenhuizen
2017-12-29 22:28:00 UTC
Reply
Permalink
Raw Message
Those are implemented as texture sampling, so we need to make the
texture TC-compatible too.

Fixes: 34d23e82ca9 "radv: set some dcc parameters depending on if texture will be sampled"
---
src/amd/vulkan/radv_device.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
index 2a249b95e28..130b4222bcd 100644
--- a/src/amd/vulkan/radv_device.c
+++ b/src/amd/vulkan/radv_device.c
@@ -3181,7 +3181,8 @@ radv_initialise_color_surface(struct radv_device *device,
max_uncompressed_block_size = V_028C78_MAX_BLOCK_SIZE_128B;
}

- if (iview->image->usage & (VK_IMAGE_USAGE_SAMPLED_BIT | VK_IMAGE_USAGE_TRANSFER_SRC_BIT)) {
+ if (iview->image->usage & (VK_IMAGE_USAGE_SAMPLED_BIT | VK_IMAGE_USAGE_TRANSFER_SRC_BIT |
+ VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT)) {
independent_64b_blocks = 1;
max_compressed_block_size = V_028C78_MAX_BLOCK_SIZE_64B;
} else
--
2.15.1
Fredrik Höglund
2017-12-29 22:36:15 UTC
Reply
Permalink
Raw Message
Post by Bas Nieuwenhuizen
Those are implemented as texture sampling, so we need to make the
texture TC-compatible too.
Fixes: 34d23e82ca9 "radv: set some dcc parameters depending on if texture will be sampled"
---
src/amd/vulkan/radv_device.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
index 2a249b95e28..130b4222bcd 100644
--- a/src/amd/vulkan/radv_device.c
+++ b/src/amd/vulkan/radv_device.c
@@ -3181,7 +3181,8 @@ radv_initialise_color_surface(struct radv_device *device,
max_uncompressed_block_size = V_028C78_MAX_BLOCK_SIZE_128B;
}
- if (iview->image->usage & (VK_IMAGE_USAGE_SAMPLED_BIT | VK_IMAGE_USAGE_TRANSFER_SRC_BIT)) {
+ if (iview->image->usage & (VK_IMAGE_USAGE_SAMPLED_BIT | VK_IMAGE_USAGE_TRANSFER_SRC_BIT |
+ VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT)) {
independent_64b_blocks = 1;
max_compressed_block_size = V_028C78_MAX_BLOCK_SIZE_64B;
} else
Loading...