[Mesa-dev] [Bug 107971] SPV_GOOGLE_hlsl_functionality1 / SPV_GOOGLE_decorate_string

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=107971

Bug ID: 107971
Summary: SPV_GOOGLE_hlsl_functionality1 /
SPV_GOOGLE_decorate_string
Product: Mesa
Version: git
Hardware: Other
OS: All
Status: NEW
Severity: enhancement
Priority: medium
Component: Drivers/Vulkan/Common
Assignee: mesa-***@lists.freedesktop.org
Reporter: ***@gmail.com
CC: ***@freedesktop.org, ***@chromium.org,
***@fooishbar.org, ***@jlekstrand.net

Created attachment 141626
--> https://bugs.freedesktop.org/attachment.cgi?id=141626&action=edit
example spirv from dxc.exe

hi,

Trying to use the "dxc" compiler to compile hlsl -> spirv and enabling
additional reflection decorations produces a spirv binary that is rejected by
mesa.


Seems to me it's because decorations of type "OpDecorateStringGOOGLE"
"OpMemberDecorateStringGOOGLE" appear in the header and cause
vtn_handle_preamble_instruction() to move on to the next section prematurely.
(if I understand correctly they should just be skipped?)

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=107971

--- Comment #1 from Bas Nieuwenhuizen <***@basnieuwenhuizen.nl> ---
Is there any extension for supporting these in vulkan? Only Google extensions I
can find in the Vulkan spec are VK_GOOGLE_display_timing and
VK_ANDROID_external_memory_android_hardware_buffer.

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=107971

--- Comment #2 from xbx <***@gmail.com> ---
I don't know. I don't think so.

It's only an spv extentension to add some additional reflection info to help
with porting from hlsl.

https://github.com/KhronosGroup/SPIRV-Registry/blob/master/extensions/GOOGLE/SPV_GOOGLE_hlsl_functionality1.asciidoc

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=107971

--- Comment #3 from Jason Ekstrand <***@jlekstrand.net> ---
Patches are on the list. Mind giving them a try?

https://patchwork.freedesktop.org/series/50971/

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=107971

--- Comment #4 from xbx <***@gmail.com> ---

thanks.

the patches work fine.

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=107971

--- Comment #5 from Jason Ekstrand <***@jlekstrand.net> ---
If you want to give me a "Tested-by" tag, I'll happily add it to the patch
before pushing.

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=107971

Emil Velikov <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED

--- Comment #6 from Emil Velikov <***@gmail.com> ---
Should be resolved with the following commit. Feel free to reopen otherwise.

commit ca4e465f7d018f8702ddb5332bf1c892b1808366
Author: Jason Ekstrand <***@intel.com>
Date: Sat Oct 13 08:46:20 2018 -0500

anv,radv: Trivially expose two new VK_GOOGLE extensions