Discussion:
[PATCH] radv: Use correct frambuffer size for partial FS resolves.
(too old to reply)
Bas Nieuwenhuizen
2017-12-27 23:21:57 UTC
Permalink
Framebuffer is from 0,0, not (dst.x, dst.y).

Fixes: 69136f4e633 "radv/meta: add resolve pass using fragment/vertex shaders"
---
src/amd/vulkan/radv_meta_resolve_fs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/amd/vulkan/radv_meta_resolve_fs.c b/src/amd/vulkan/radv_meta_resolve_fs.c
index b937c12ec11..f34e387a07d 100644
--- a/src/amd/vulkan/radv_meta_resolve_fs.c
+++ b/src/amd/vulkan/radv_meta_resolve_fs.c
@@ -540,8 +540,8 @@ void radv_meta_resolve_fragment_image(struct radv_cmd_buffer *cmd_buffer,
.pAttachments = (VkImageView[]) {
radv_image_view_to_handle(&dest_iview),
},
- .width = extent.width,
- .height = extent.height,
+ .width = extent.width + dstOffset.x,
+ .height = extent.height + dstOffset.y,
.layers = 1
}, &cmd_buffer->pool->alloc, &fb);
--
2.15.1
Dave Airlie
2017-12-27 23:24:14 UTC
Permalink
Post by Bas Nieuwenhuizen
Framebuffer is from 0,0, not (dst.x, dst.y).
Fixes: 69136f4e633 "radv/meta: add resolve pass using fragment/vertex shaders"
Reviewed-by: Dave Airlie <***@redhat.com>

Dave.

Loading...