[Mesa-dev] [Bug 107565] TypeError: __init__() got an unexpected keyword argument 'future_imports'

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=107565

Bug ID: 107565
Summary: TypeError: __init__() got an unexpected keyword
argument 'future_imports'
Product: Mesa
Version: git
Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: NEW
Keywords: bisected, regression
Severity: normal
Priority: medium
Component: Mesa core
Assignee: mesa-***@lists.freedesktop.org
Reporter: ***@freedesktop.org
QA Contact: mesa-***@lists.freedesktop.org
CC: ***@gmail.com, ***@daitauha.fr,
fdo-***@engestrom.ch

Build error with Python 2.6.

GEN main/format_unpack.c
Traceback (most recent call last):
File "./main/format_unpack.py", line 893, in <module>
template = Template(string, future_imports=['division']);
TypeError: __init__() got an unexpected keyword argument 'future_imports'

commit 9b6746b7c0bef64be419c8cf2ecd916980e2718a
Author: Mathieu Bridon <***@daitauha.fr>
Date: Wed Jul 25 11:53:54 2018 +0200

python: Use explicit integer divisions

32 / 4

8

32 / 4

8.0

32 // 4

8

That operator exists on Python >= 2.2, so let's use it everywhere to
make the scripts compatible with both Python 2 and 3.

In addition, using __future__.division tells Python 2 to behave the same
way as Python 3, which helps ensure the scripts produce the same output
in both versions of Python.

Signed-off-by: Mathieu Bridon <***@daitauha.fr>
Reviewed-by: Eric Engestrom <***@intel.com> (v2)
Reviewed-by: Dylan Baker <***@pnwbakers.com>

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=107565

--- Comment #1 from Dylan Baker <***@gmail.com> ---
Scons doesn't check that mako is at least 0.8.0 like autotools does (which was
released in 2013, btw). The real bug here is that scons doesn't do proper
checks like it should.

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=107565

Dylan Baker <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Assignee|mesa-***@lists.freedesktop. |***@gmail.com
|org |

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=107565

Emil Velikov <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED

--- Comment #2 from Emil Velikov <***@gmail.com> ---
Should be fixed with the following commit. Feel free to reopen otherwise.

commit c782168751ec6373c28ebb4b4c39a8f3ae06a075
Author: Dylan Baker <***@pnwbakers.com>
Date: Tue Aug 14 10:32:12 2018 -0700

scons: Check for mako 0.8.0