[Mesa-dev] [Bug 108961] make check test_replace_src_bitsize failure

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=108961

Bug ID: 108961
Summary: make check test_replace_src_bitsize failure
Product: Mesa
Version: git
Hardware: x86-64 (AMD64)
OS: All
Status: NEW
Keywords: bisected, regression
Severity: normal
Priority: medium
Component: Mesa core
Assignee: mesa-***@lists.freedesktop.org
Reporter: ***@freedesktop.org
QA Contact: mesa-***@lists.freedesktop.org
CC: ***@gmail.com, ***@gmail.com,
***@jlekstrand.net

FAIL: test_replace_src_bitsize (__main__.ValidatorTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "./nir/tests/algebraic_parser_test.py", line 70, in
test_replace_src_bitsize
"Sources a (bit size of a) and b (bit size of 32) " \
File "./nir/tests/algebraic_parser_test.py", line 47, in common
self.assertEqual(message, str(context.exception))
AssertionError: "Sources a (bit size of a) and b (bit size of 32) of ('iadd',
'a', 'b') may not have the same bit size when building the replacement
expression." != "Sources a (bit size of a) and b (bit size of b) of ('iadd',
'a', 'b') may not have the same bit size when building the replacement
expression."


commit a0ae12ca91a45f81897e774019cde9bd081f03a0
Author: Connor Abbott <***@gmail.com>
Date: Thu Nov 29 17:46:59 2018 +0100

nir/algebraic: Add unit tests for bitsize validation

The non-failure path can be tested by just compiling mesa and then
testing it, but the failure paths won't be hit unless you make a mistake,
so it's best to test them with some unit tests.

Reviewed-by: Jason Ekstrand <***@jlekstrand.net>
Reviewed-by: Dylan Baker <***@pnwbakers.com>

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=108961

Jason Ekstrand <***@jlekstrand.net> changed:

What |Removed |Added
----------------------------------------------------------------------------
Assignee|mesa-***@lists.freedesktop. |***@gmail.com
|org |

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=108961

Connor Abbott <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED

--- Comment #1 from Connor Abbott <***@gmail.com> ---
commit 2845c492187bbf763e06c5b4325fdac8fdc027c8
Author: Connor Abbott <***@gmail.com>
Date: Fri Dec 7 10:48:22 2018 +0100

nir: Fixup algebraic test for variable-sized conversions

b2i can now take any size boolean in preparation for 1-bit booleans, so
the error message printed is slightly different.

Fixes: dca6cd9ce65 ("nir: Make boolean conversions sized just like the
others")
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108961
Cc: Jason Ekstrand <***@jlekstrand.net>
Acked-by: Jason Ekstrand <***@jlekstrand.net>