Discussion:
[PATCH] vulkan/wsi: free cmd pools
(too old to reply)
Dave Airlie
2017-12-27 23:47:27 UTC
Permalink
From: Dave Airlie <***@redhat.com>

We destroy the pools but don't free the container.

This fixes:
dEQP-VK.wsi.xlib.swapchain.simulate_oom*

Fixes: d50937f137 (vulkan/wsi: Implement prime in a completely generic way)
Signed-off-by: Dave Airlie <***@redhat.com>
---
src/vulkan/wsi/wsi_common.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/src/vulkan/wsi/wsi_common.c b/src/vulkan/wsi/wsi_common.c
index 2de5f15..e9e43e1 100644
--- a/src/vulkan/wsi/wsi_common.c
+++ b/src/vulkan/wsi/wsi_common.c
@@ -156,6 +156,7 @@ wsi_swapchain_finish(struct wsi_swapchain *chain)
chain->wsi->DestroyCommandPool(chain->device, chain->cmd_pools[i],
&chain->alloc);
}
+ vk_free(&chain->alloc, chain->cmd_pools);
}

static uint32_t
--
2.9.5
Bas Nieuwenhuizen
2017-12-27 23:49:39 UTC
Permalink
Post by Dave Airlie
We destroy the pools but don't free the container.
dEQP-VK.wsi.xlib.swapchain.simulate_oom*
Fixes: d50937f137 (vulkan/wsi: Implement prime in a completely generic way)
---
src/vulkan/wsi/wsi_common.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/vulkan/wsi/wsi_common.c b/src/vulkan/wsi/wsi_common.c
index 2de5f15..e9e43e1 100644
--- a/src/vulkan/wsi/wsi_common.c
+++ b/src/vulkan/wsi/wsi_common.c
@@ -156,6 +156,7 @@ wsi_swapchain_finish(struct wsi_swapchain *chain)
chain->wsi->DestroyCommandPool(chain->device, chain->cmd_pools[i],
&chain->alloc);
}
+ vk_free(&chain->alloc, chain->cmd_pools);
}
static uint32_t
--
2.9.5
_______________________________________________
mesa-dev mailing list
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Loading...