Discussion:
[PATCH 2/2] svga: fix TGSI_TEXTURE_SHADOW1D coordinate selection
(too old to reply)
Brian Paul
2017-12-24 05:13:47 UTC
Permalink
Fixes about 24 Piglit tex-miplevel-selection tests.
---
src/gallium/drivers/svga/svga_tgsi_vgpu10.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/gallium/drivers/svga/svga_tgsi_vgpu10.c b/src/gallium/drivers/svga/svga_tgsi_vgpu10.c
index deb8e5a..31149dd 100644
--- a/src/gallium/drivers/svga/svga_tgsi_vgpu10.c
+++ b/src/gallium/drivers/svga/svga_tgsi_vgpu10.c
@@ -4898,12 +4898,10 @@ end_tex_swizzle(struct svga_shader_emitter_v10 *emit,
switch (swz->texture_target) {
case TGSI_TEXTURE_SHADOW2D:
case TGSI_TEXTURE_SHADOWRECT:
+ case TGSI_TEXTURE_SHADOW1D:
case TGSI_TEXTURE_SHADOW1D_ARRAY:
coord_src = scalar_src(swz->coord_src, TGSI_SWIZZLE_Z);
break;
- case TGSI_TEXTURE_SHADOW1D:
- coord_src = scalar_src(swz->coord_src, TGSI_SWIZZLE_Y);
- break;
case TGSI_TEXTURE_SHADOWCUBE:
case TGSI_TEXTURE_SHADOW2D_ARRAY:
coord_src = scalar_src(swz->coord_src, TGSI_SWIZZLE_W);
--
1.9.1
Charmaine Lee
2017-12-26 19:38:26 UTC
Permalink
For the series, Reviewed-by: Charmaine Lee <***@vmware.com>

________________________________________
From: Brian Paul <***@vmware.com>
Sent: Saturday, December 23, 2017 9:13:47 PM
To: mesa-***@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH 2/2] svga: fix TGSI_TEXTURE_SHADOW1D coordinate selection

Fixes about 24 Piglit tex-miplevel-selection tests.
---
src/gallium/drivers/svga/svga_tgsi_vgpu10.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/gallium/drivers/svga/svga_tgsi_vgpu10.c b/src/gallium/drivers/svga/svga_tgsi_vgpu10.c
index deb8e5a..31149dd 100644
--- a/src/gallium/drivers/svga/svga_tgsi_vgpu10.c
+++ b/src/gallium/drivers/svga/svga_tgsi_vgpu10.c
@@ -4898,12 +4898,10 @@ end_tex_swizzle(struct svga_shader_emitter_v10 *emit,
switch (swz->texture_target) {
case TGSI_TEXTURE_SHADOW2D:
case TGSI_TEXTURE_SHADOWRECT:
+ case TGSI_TEXTURE_SHADOW1D:
case TGSI_TEXTURE_SHADOW1D_ARRAY:
coord_src = scalar_src(swz->coord_src, TGSI_SWIZZLE_Z);
break;
- case TGSI_TEXTURE_SHADOW1D:
- coord_src = scalar_src(swz->coord_src, TGSI_SWIZZLE_Y);
- break;
case TGSI_TEXTURE_SHADOWCUBE:
case TGSI_TEXTURE_SHADOW2D_ARRAY:
coord_src = scalar_src(swz->coord_src, TGSI_SWIZZLE_W);
--
1.9.1
Neha Bhende
2017-12-26 20:07:49 UTC
Permalink
For the series,


Reviewed-by: Neha Bhende<***@vmware.com>


Regards,

Neha


________________________________
From: Brian Paul <***@vmware.com>
Sent: Saturday, December 23, 2017 9:13 PM
To: mesa-***@lists.freedesktop.org
Cc: Charmaine Lee; Neha Bhende
Subject: [PATCH 2/2] svga: fix TGSI_TEXTURE_SHADOW1D coordinate selection

Fixes about 24 Piglit tex-miplevel-selection tests.
---
src/gallium/drivers/svga/svga_tgsi_vgpu10.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/gallium/drivers/svga/svga_tgsi_vgpu10.c b/src/gallium/drivers/svga/svga_tgsi_vgpu10.c
index deb8e5a..31149dd 100644
--- a/src/gallium/drivers/svga/svga_tgsi_vgpu10.c
+++ b/src/gallium/drivers/svga/svga_tgsi_vgpu10.c
@@ -4898,12 +4898,10 @@ end_tex_swizzle(struct svga_shader_emitter_v10 *emit,
switch (swz->texture_target) {
case TGSI_TEXTURE_SHADOW2D:
case TGSI_TEXTURE_SHADOWRECT:
+ case TGSI_TEXTURE_SHADOW1D:
case TGSI_TEXTURE_SHADOW1D_ARRAY:
coord_src = scalar_src(swz->coord_src, TGSI_SWIZZLE_Z);
break;
- case TGSI_TEXTURE_SHADOW1D:
- coord_src = scalar_src(swz->coord_src, TGSI_SWIZZLE_Y);
- break;
case TGSI_TEXTURE_SHADOWCUBE:
case TGSI_TEXTURE_SHADOW2D_ARRAY:
coord_src = scalar_src(swz->coord_src, TGSI_SWIZZLE_W);
--
1.9.1
Loading...