[Mesa-dev] [Bug 108578] RADV reports wrong hardcoded Vulkan API Version

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=108578

Bug ID: 108578
Summary: RADV reports wrong hardcoded Vulkan API Version
Product: Mesa
Version: git
Hardware: Other
OS: All
Status: NEW
Severity: trivial
Priority: medium
Component: Drivers/Vulkan/radeon
Assignee: mesa-***@lists.freedesktop.org
Reporter: ***@gmail.com
QA Contact: mesa-***@lists.freedesktop.org

Created attachment 142240
--> https://bugs.freedesktop.org/attachment.cgi?id=142240&action=edit
vulkaninfo output

Apps that get additional info like DXVK HUD or vulkaninfo reports Vulkan=1.1.70
because it is hardcoded as so in
https://gitlab.freedesktop.org/mesa/mesa/blob/master/src/amd/vulkan/radv_extensions.py#L34

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=108578

--- Comment #1 from Shmerl <***@gmail.com> ---
Generated ICD (radeon_icd.x86_64.json) looks like this for me (Mesa master):

"ICD": {
"api_version": "1.1.70",
...

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=108578

--- Comment #2 from Bas Nieuwenhuizen <***@basnieuwenhuizen.nl> ---
Why do you think it is wrong?

We hardcode it because every version bump we need to see if we have implemented
the non-extension API changes+bugfixes in the driver, and apparently the last
time we did that we did so for up to 1.1.70.

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=108578

--- Comment #3 from ***@gmail.com ---
I still don't understand the reasoning. The version referenced here
https://gitlab.freedesktop.org/mesa/mesa/commit/13fd4e601c80b85317feac894c52bd24e4f98c09
for instance is different (1.1.88).

By non-extension you mean just the icd loader?

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=108578

Samuel Pitoiset <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |NOTABUG

--- Comment #4 from Samuel Pitoiset <***@gmail.com> ---
This is not a bug. We should be able to bump the patch version but that
requires to look at the changelog since 1.1.70.

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=108578

--- Comment #5 from Shmerl <***@gmail.com> ---
(In reply to Samuel Pitoiset from comment #4)

Post by b***@freedesktop.org
This is not a bug. We should be able to bump the patch version but that
requires to look at the changelog since 1.1.70.

Do you mean it's a review issue, i.e. someone needs to go over it and confirm
that all needed features are supported?

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=108578

--- Comment #6 from Samuel Pitoiset <***@gmail.com> ---
Yes, exactly.