Discussion:
[Mesa-dev] [PATCH] nir: Fixup algebraic test for variable-sized conversions
Connor Abbott
2018-12-07 09:53:27 UTC
Permalink
b2i can now take any size boolean in preparation for 1-bit booleans, so
the error message printed is slightly different.

Fixes: dca6cd9ce65 ("nir: Make boolean conversions sized just like the others")
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108961
Cc: Jason Ekstrand <***@jlekstrand.net>
---
src/compiler/nir/tests/algebraic_parser_test.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/compiler/nir/tests/algebraic_parser_test.py b/src/compiler/nir/tests/algebraic_parser_test.py
index 492a09ec7db..d96da7db519 100644
--- a/src/compiler/nir/tests/algebraic_parser_test.py
+++ b/src/compiler/nir/tests/algebraic_parser_test.py
@@ -67,7 +67,7 @@ class ValidatorTests(unittest.TestCase):

def test_replace_src_bitsize(self):
self.common((('iadd', a, ('b2i', b)), ('iadd', a, b)),
- "Sources a (bit size of a) and b (bit size of 32) " \
+ "Sources a (bit size of a) and b (bit size of b) " \
"of ('iadd', 'a', 'b') may not have the same bit size " \
"when building the replacement expression.")
--
2.17.2
Jason Ekstrand
2018-12-07 14:28:37 UTC
Permalink
Ack
Post by Connor Abbott
b2i can now take any size boolean in preparation for 1-bit booleans, so
the error message printed is slightly different.
Fixes: dca6cd9ce65 ("nir: Make boolean conversions sized just like the others")
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108961
---
src/compiler/nir/tests/algebraic_parser_test.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/compiler/nir/tests/algebraic_parser_test.py
b/src/compiler/nir/tests/algebraic_parser_test.py
index 492a09ec7db..d96da7db519 100644
--- a/src/compiler/nir/tests/algebraic_parser_test.py
+++ b/src/compiler/nir/tests/algebraic_parser_test.py
self.common((('iadd', a, ('b2i', b)), ('iadd', a, b)),
- "Sources a (bit size of a) and b (bit size of 32) " \
+ "Sources a (bit size of a) and b (bit size of b) " \
"of ('iadd', 'a', 'b') may not have the same bit size " \
"when building the replacement expression.")
--
2.17.2
Loading...