[Mesa-dev] [PATCH] meson: link LLVM 'native' component when LLVM is available

[Nicolai Hähnle]

From: Nicolai Hähnle <***@amd.com>

Linking against LLVM built with BUILD_SHARED_LIBS fails otherwise,
as the component is required for the draw module.
---
meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meson.build b/meson.build
index 1aeef95f722..0177716c476 100644
--- a/meson.build
+++ b/meson.build
@@ -1155,21 +1155,21 @@ dep_libdrm = dependency(
if dep_libdrm.found()
pre_args += '-DHAVE_LIBDRM'
if with_dri_platform == 'drm' and with_dri
with_gallium_drisw_kms = true
endif
endif

llvm_modules = ['bitwriter', 'engine', 'mcdisassembler', 'mcjit']
llvm_optional_modules = []
if with_amd_vk or with_gallium_radeonsi or with_gallium_r600
- llvm_modules += ['amdgpu', 'bitreader', 'ipo']
+ llvm_modules += ['amdgpu', 'native', 'bitreader', 'ipo']
if with_gallium_r600
llvm_modules += 'asmparser'
endif
endif
if with_gallium_opencl
llvm_modules += [
'all-targets', 'linker', 'coverage', 'instrumentation', 'ipo', 'irreader',
'lto', 'option', 'objcarcopts', 'profiledata',
]
llvm_optional_modules += ['coroutines']

[Dylan Baker]

Quoting Nicolai HÀhnle (2018-12-06 05:49:02)

Post by Nicolai Hähnle
Linking against LLVM built with BUILD_SHARED_LIBS fails otherwise,
as the component is required for the draw module.
---
meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index 1aeef95f722..0177716c476 100644
--- a/meson.build
+++ b/meson.build
@@ -1155,21 +1155,21 @@ dep_libdrm = dependency(
if dep_libdrm.found()
pre_args += '-DHAVE_LIBDRM'
if with_dri_platform == 'drm' and with_dri
with_gallium_drisw_kms = true
endif
endif
llvm_modules = ['bitwriter', 'engine', 'mcdisassembler', 'mcjit']
llvm_optional_modules = []
if with_amd_vk or with_gallium_radeonsi or with_gallium_r600
- llvm_modules += ['amdgpu', 'bitreader', 'ipo']
+ llvm_modules += ['amdgpu', 'native', 'bitreader', 'ipo']
if with_gallium_r600
llvm_modules += 'asmparser'
endif
endif
if with_gallium_opencl
llvm_modules += [
'all-targets', 'linker', 'coverage', 'instrumentation', 'ipo', 'irreader',
'lto', 'option', 'objcarcopts', 'profiledata',
]
llvm_optional_modules += ['coroutines']
--
2.19.1

Reviewed-by: Dylan Baker <***@pnwbakers.com>

[Emil Velikov]

Hi Nicolai,

Post by Nicolai Hähnle
Linking against LLVM built with BUILD_SHARED_LIBS fails otherwise,
as the component is required for the draw module.

I'd imagine we'd want this for stable, since the "native" module has
been used for a while?

4275cae95c8 meson: link LLVM 'native' component when LLVM is available

-Emil

[Haehnle, Nicolai]

Post by Emil Velikov
Hi Nicolai,

Post by Nicolai Hähnle
Linking against LLVM built with BUILD_SHARED_LIBS fails otherwise,
as the component is required for the draw module.

I'd imagine we'd want this for stable, since the "native" module has
been used for a while?
4275cae95c8 meson: link LLVM 'native' component when LLVM is available

Yeah, seems like that would make sense.

Cheers,
Nicolai

Post by Emil Velikov
-Emil

[Juan A. Suarez Romero]

Post by Haehnle, Nicolai

Post by Emil Velikov
Hi Nicolai,

Post by Nicolai Hähnle
Linking against LLVM built with BUILD_SHARED_LIBS fails otherwise,
as the component is required for the draw module.

I'd imagine we'd want this for stable, since the "native" module has
been used for a while?
4275cae95c8 meson: link LLVM 'native' component when LLVM is available

Yeah, seems like that would make sense.

Added also in 18.2 stable queue.


J.A.

Post by Haehnle, Nicolai
Cheers,
Nicolai

Post by Emil Velikov
-Emil

_______________________________________________
mesa-stable mailing list
https://lists.freedesktop.org/mailman/listinfo/mesa-stable