[Mesa-dev] [Bug 100960] Special block from Minecraft mod rendered out of place

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=100960

Bug ID: 100960
Summary: Special block from Minecraft mod rendered out of place
Product: Mesa
Version: git
Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: NEW
Severity: minor
Priority: medium
Component: Mesa core
Assignee: mesa-***@lists.freedesktop.org
Reporter: ***@web.de
QA Contact: mesa-***@lists.freedesktop.org

Created attachment 131243
--> https://bugs.freedesktop.org/attachment.cgi?id=131243&action=edit
Compressed apitrace, 142MB unpacked

Running a certain mod (ProjectE) with Minecraft results in a special block
being rendered to high. It's hard to describe, please check the apitrace and
screenshots for more info.
LIBGL_ALWAYS_SOFTWARE doesn't change the result.

Apitrace attached.
Images in following comments, both taken from frame 850 of the trace file:
-One on linux
-One on win10 with latest closed source AMD drivers.

System the bug was tested on:
- Arch Linux 64bit
- Linux 4.10.13, AMDGPU driver
- Mesa 17.2.0-devel (git-ccf9669cc1) / Mesa 17.0.5
- Radeon R9 285

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=100960

--- Comment #1 from Fabian Maurer <***@web.de> ---
Created attachment 131244
--> https://bugs.freedesktop.org/attachment.cgi?id=131244&action=edit
screenshot (working) on windows

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=100960

--- Comment #2 from Fabian Maurer <***@web.de> ---
Created attachment 131245
--> https://bugs.freedesktop.org/attachment.cgi?id=131245&action=edit
screenshot(broken) on linux

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=100960

--- Comment #4 from Fabian Maurer <***@web.de> ---
Yes, the screenshot from comment 1 is from the same apitrace, but taken on
windows.
I also retested on linux, and as of Mesa 18.2.0-devel (git-bd35345e85) the
issue is still present.

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=100960

Timothy Arceri <***@yahoo.com.au> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |NEEDINFO

--- Comment #3 from Timothy Arceri <***@yahoo.com.au> ---
If you replay the trace on windows does it render correctly?

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=100960

Timothy Arceri <***@yahoo.com.au> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |NEW

--- Comment #5 from Timothy Arceri <***@yahoo.com.au> ---
I can confirm this renders correctly on Nvidia's Linux driver.

The rendering of the block can be seen in Frame 815 via three calls to
glCallList().

glCallList(55503), glCallList(55504) and glCallList(55505)

These call lists are compiled in Frame 814.

Editing the y param to the glTranslatef() call that exists before glCallList()
is called allows us to move the block to a more correct location.

There are a bunch of gl{Push,Pop}Matrix() calls before this but as far as I can
tell Mesa's implementation of these functions looks fine.

I couldn't find any reason for the block to be rendered in the wrong position
on Mesa drivers but thought I'd record this information in case anyone else
wants to take a look.

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=100960

--- Comment #6 from Sergii Romantsov <***@globallogic.com> ---
Also doesn't work on Intel: Intel HD Graphics 620 (Kaby Lake GT2)
with git master and 13.0.6

Proposed workaround: https://patchwork.freedesktop.org/patch/249043/

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=100960

--- Comment #8 from Sergii Romantsov <***@globallogic.com> ---
Created attachment 141542
--> https://bugs.freedesktop.org/attachment.cgi?id=141542&action=edit
trimmed and modified trace

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=100960

--- Comment #7 from Sergii Romantsov <***@globallogic.com> ---
Hello, Fabian.
Could i ask you to check one thing?
I'm attaching modified and trimmed trace: trimmmed.tar.gz.
Will you able to run it on Windows
(https://people.freedesktop.org/~jrfonseca/apitrace/)?
If yes, then, please, do:
1. move to the latest call "2245521 @0 glPopMatrix()"
2. lookup it state
3. after its played, than 'current state' will appear on the right side
4. please, attach image from 'Surfaces/Framebuffers'

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=100960

--- Comment #9 from Fabian Maurer <***@web.de> ---
Created attachment 141566
--> https://bugs.freedesktop.org/attachment.cgi?id=141566&action=edit
Windows - Call 2245521 - Framebuffer

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=100960

--- Comment #10 from Sergii Romantsov <***@globallogic.com> ---
Thanks, Fabian.
That proves that Windows has a workaround for (0,0,0)-vector and treat it as
(1,0,0)-vector

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=100960

--- Comment #11 from Sergii Romantsov <***@globallogic.com> ---
Hello again.
Fabian, could you, please, do one more thing: use trace vr.trace and provide an
image that it gives on Windows?

And Timothy, could you, please, do the same for Nvidia Linux driver?

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=100960

--- Comment #12 from Sergii Romantsov <***@globallogic.com> ---
Created attachment 141846
--> https://bugs.freedesktop.org/attachment.cgi?id=141846&action=edit
vr.trace

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=100960

--- Comment #13 from Fabian Maurer <***@web.de> ---
Created attachment 141856
--> https://bugs.freedesktop.org/attachment.cgi?id=141856&action=edit
vr.trace windows picture

Attaching the requested picture.

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=100960

--- Comment #14 from Sergii Romantsov <***@globallogic.com> ---
Thanks, Fabian. Your image looks the same as mesa with patch
https://patchwork.freedesktop.org/patch/249043/ v3

Proposed additionally piglit-test:
https://patchwork.freedesktop.org/patch/255629/

Apitrace to check on other platforms: zero-vector-rotate.trace.tar.gz
The final version of test gives image: Mesa_zero-vector-rotate.png

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=100960

--- Comment #15 from Sergii Romantsov <***@globallogic.com> ---
Created attachment 141973
--> https://bugs.freedesktop.org/attachment.cgi?id=141973&action=edit
Mesa_zero-vector-rotate.png

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=100960

--- Comment #16 from Sergii Romantsov <***@globallogic.com> ---
Created attachment 141974
--> https://bugs.freedesktop.org/attachment.cgi?id=141974&action=edit
zero-vector-rotate.trace.tar.gz

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=100960

--- Comment #17 from Sergii Romantsov <***@globallogic.com> ---
Hello, Fabian.

Unfortunately, probably, no one will be interest in that fix in the Mesa so
much.
The reason: actually issue is in the game. Specification doesn't specify exact
way how to handle it. So at this moment its implementation-dependent.

Suggestion is: please, post an issue to Minecraft-mod owner. Probably, that is
the fastest way to fix it: instead of calls
'glRotated(angle = 180, x = 0, y = 0, z = 0)'
application should call:
'glRotated(angle = 180, x = 1, y = 0, z = 0)'.
And, please, provide a link to it.

Proposed patches are still actual and adds compatibility for Mesa with Nvidia
and Windows. But still: current behavior of Mesa is also can be treated as
'correct'.

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=100960

--- Comment #18 from Sergii Romantsov <***@globallogic.com> ---
Hello, Fabian.
At this moment i'm looking on possibility to workaround it only for Minecraft.
Could i ask for a help?:
1. To run Minecraft with mod
2. To get outputs of:
2.1 ps -fux
2.2 sudo grep i965_dri.so /proc/*/maps
3. And attach outputs here

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=100960

--- Comment #19 from Fabian Maurer <***@web.de> ---
Hey there, sorry for the late answer.

The mod has fixed the issue in its latest version, so for me this issue isn't
relevant anymore. Do we still want a change in this, or do we consider this a
"NOTOURBUG"?

Sidenote, why i965_dri.so? I though I'm using radeonsi.

[b***@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=100960

--- Comment #20 from Tapani PÀlli <***@gmail.com> ---
(In reply to Fabian Maurer from comment #19)

Post by b***@freedesktop.org
Hey there, sorry for the late answer.
The mod has fixed the issue in its latest version, so for me this issue
isn't relevant anymore. Do we still want a change in this, or do we consider
this a "NOTOURBUG"?
Sidenote, why i965_dri.so? I though I'm using radeonsi.

IMO NOTOURBUG seems the correct resolution here